Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes govuk-grid-row mixin #1343

Merged
merged 2 commits into from
May 14, 2019
Merged

Removes govuk-grid-row mixin #1343

merged 2 commits into from
May 14, 2019

Conversation

aliuk2012
Copy link
Contributor

#1090 copied govuk-grid-row
mixin to create a new concrete .govuk-grid-row class and marked the mixin as deprecated.

ACTION TO BE TAKEN: Remove any references to govuk-grid-row mixin and
use .govuk-grid-row class.

closes: #1092

@aliuk2012
removes deprecated govuk-grid-row mixin
3472066 
#1090 copied govuk-grid-row
mixin to create a new concrete `.govuk-grid-row` class and marked the mixin as deprecated.

ACTION TO BE TAKEN: Remove any references to `govuk-grid-row` mixin and
                    use `.govuk-grid-row` class.

closes: #1092
@aliuk2012 aliuk2012 added this to the v3.0.0 milestone May 14, 2019
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1343 May 14, 2019 07:59 Inactive
@aliuk2012 aliuk2012 marked this pull request as ready for review May 14, 2019 08:08
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1343 May 14, 2019 08:08 Inactive
36degrees
36degrees approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but not sure about the changelog format.

CHANGELOG.md Outdated Show resolved Hide resolved
@aliuk2012 aliuk2012 force-pushed the remove-govuk-grid-row-mixin branch from 64ad1b1 to 9424d87 Compare May 14, 2019 08:50
@aliuk2012 aliuk2012 merged commit c1e32cb into v3 May 14, 2019
@aliuk2012 aliuk2012 deleted the remove-govuk-grid-row-mixin branch May 14, 2019 09:14
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aliuk2012 @36degrees @govuk-design-system-ci