Underline meta information links in footer #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1332
NickColley
force-pushed
the
underline-meta-information-in-footer
branch
from
ceb0bce
to
9f7af30
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1332
|
I don't really have a preference either way, but wondering if it'd make sense to only take the underline away for links inside It'd also mean if we added additional elements to the footer in the future they'd get underlines unless we explicitly removed them. |
|
Yeah lets do that |
NickColley
force-pushed
the
underline-meta-information-in-footer
branch
from
9f7af30
to
b202d41
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1332
We want most links to not have a default underline, but keep it for the meta information links
NickColley
force-pushed
the
underline-meta-information-in-footer
branch
from
b202d41
to
1f9106b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Dave's comments on #1321 (comment)