Fixes an issue with styling links #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1310
aliuk2012
changed the title
NickColley
approved these changes
May 1, 2019
aliuk2012
force-pushed
the
fixes-visible-links
branch
from
37ebbc0
to
e7ae104
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1310
hannalaakso
reviewed
May 1, 2019
aliuk2012
force-pushed
the
fixes-visible-links
branch
from
e7ae104
to
c1145b9
Compare
When visiting the links example page, if you had previously visited the home page then the unvisited link and visited link example looked identical. This commit passes a random number to the view. The view adds the randomId to the href as a hash. Co-authored-by: Nick Colley <[email protected]>
govuk-elements uses specific css selector`a:link:focus` whereas govuk-frontend uses `.govuk-link:focus`. This fix makes govuk-frontend selector more specific `.govuk-link:link:focus` but only when compatibility mode is being used. Co-authored-by: Nick Colley <[email protected]>
hannalaakso
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When visiting the links example page, if you had previously visited the
home page then the unvisited link and visited link example looked identical.
This commit passes a random number to the view. The view adds the randomId
to the href as a hash.
👉 https://govuk-frontend-review-pr-1310.herokuapp.com/examples/links
Before
After