Prevent duplicate checkbox aria-describedby #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
force-pushed
the
duplicate-single-checkbox-aria
branch
from
bbfe950 to
fe527c1
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1265
kellylee-gds
added
🕔 hours
hannalaakso
reviewed
Apr 5, 2019
There was a problem hiding this comment.
Looks good to me, thanks @colinrotherham 🙌 Just left one comment. We'll also need a second reviewer from our team to take a look.
aliuk2012
suggested changes
Apr 5, 2019
|
Thanks for the feedback. I've been in Nunjucks land a while now, will make it simpler! |
colinrotherham
force-pushed
the
duplicate-single-checkbox-aria
branch
from
fe527c1 to
60d6742
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1265
colinrotherham
force-pushed
the
duplicate-single-checkbox-aria
branch
from
60d6742 to
7c818bf
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1265
|
@aliuk2012 I needed to support this new hybrid case (previously untested) so I've pushed a slightly revised version up: https://govuk-frontend-review-pr-1265.herokuapp.com/components/checkboxes/with-error-message-and-hints-on-items/preview As mentioned on the diffs, it's to cater for:
@hannalaakso If you'd still prefer those Nunjucks if/else simplifying further let me know. |
The fieldset has the `aria-describedby` so we don’t need it on the input
colinrotherham
force-pushed
the
duplicate-single-checkbox-aria
branch
from
7c818bf to
c5e923c
Compare
|
Rebased with |
aliuk2012
approved these changes
Apr 5, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spent a bit of time in the checkbox component recently (passing
describedByaround) so I've fixed #1248 as it'll benefit our work as well.