Ensure inset component does not misalign nested components #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with any other usage of pseudo selectors that remove unwanted spacing in children.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1232
NickColley
changed the title
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1232
NickColley
force-pushed
the
ensure-component-css-are-one-level-deep
branch
from
33a1d99
to
92e8815
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures any children of the inset component are only targeted one level deep, which is consistent with the other uses of this pseudo selector in other components.
Fixes #1225
Screenshots
Before
After