Update summary list to simplify actions #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only render a list when there are more than one action.
Since links wont always be in a list, move the right alignment to the parent.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1131
NickColley
commented
Jan 14, 2019
| <dl class="govuk-summary-list {%- if params.classes %} {{ params.classes }}{% endif %}"{% for attribute, value in params.attributes %} {{attribute}}="{{value}}"{% endfor %}> | ||
| {% for row in params.rows %} | ||
| <div class="govuk-summary-list__row"> | ||
| <dt class="govuk-summary-list__key {%- if row.key.classes %} {{ row.key.classes }}{% endif %}"> | ||
| {{ row.key.html | safe if row.key.html else row.key.text }} | ||
| </dt> | ||
| <dd class="govuk-summary-list__value {%- if row.value.classes %} {{ row.value.classes }}{% endif %}"> | ||
| {{ row.value.html | safe if row.value.html else row.value.text }} | ||
| {{ row.value.html | indent(8) | trim | safe if row.value.html else row.value.text }} |
There was a problem hiding this comment.
indent and trim filters is just to make the output markup easier to read
|
Yeh this is great work, thanks @NickColley ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While my head is still in this component I thought I'd see if we can only output actions in a list when there's multiple actions.
This means in the most common case of a single action the markup is simpler.
Closes #1128