add error message attributes to components #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36degrees
approved these changes
Dec 11, 2018
There was a problem hiding this comment.
Thanks for this, @danboscaro – changes look good to me.
This will need a review from one other person from our team and then we can get this merged for you.
NickColley
approved these changes
Dec 11, 2018
|
Let us know if this is blocking you and we can try to release this as soon as possible. Otherwise you can watch the repository for a new release in the future:
|
|
Hi Nick. This is blocking me from adding some html properties for google analytics requirements on my existing project. It would help to have it released as soon as possible, please. Thanks. |
|
@jegsivam We're aiming to release this today thanks for letting me know :) |
Merged
|
@danboscaro @jegsivam we've released this as version 2.4.1 thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all components currently arent passing on error message attributes to their error message sub component
this pull request is simply adding that in