Fix anchor links in tabs component panels #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this selector was fairly specific enough, but by explicitly using a govuk-frontend class, this removes any last issues. Unless a user tries to nest tabs...
This ensures that any anchors that are in a tab panel do not get mistaken for a tab by reusing the `getTab` function that now is more specific.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1031
NickColley
changed the title
|
@NickColley thanks a lot for looking into this! 🙏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1030
When clicking an anchor in the tabs component panel, it will trigger the 'hashchange' event which the tabs component is listening to.
The component then checks to see if there's any tabs within the component that match this hash, but did so in a way that could also include regular anchor links.
This pull request ensures it is only checking that the hash matches available tabs only.
I've also tested the following scenarios manually: