You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a few components that be configured using data attributes set at the component level (on the same HTML element that has the data-module attribute). This includes:
button (data-prevent-double-click)
character count (data-maxwords, data-maxlength and data-threshold)
error summary (data-disable-auto-focus)
notification banner (data-disable-auto-focus)
Update these components so that the same config can be set via config at the point of initialisation, for example:
This does not cover data attributes are used on elements ‘within’ a component, like the data-behaviour attribute used on individual checkboxes within the checkboxes component.
Update the notification banner to merge the config from the config object passed at the point of construction with any data attributes, following the conventions established as part of #2808.
Co-authored-by: Romaric Pascal <[email protected]>
Update the notification banner to merge the config from the config object passed at the point of construction with any data attributes, following the conventions established as part of #2808.
Co-authored-by: Romaric Pascal <[email protected]>
What
We have a few components that be configured using data attributes set at the component level (on the same HTML element that has the
data-module
attribute). This includes:data-prevent-double-click
)data-maxwords
,data-maxlength
anddata-threshold
)data-disable-auto-focus
)data-disable-auto-focus
)Update these components so that the same config can be set via config at the point of initialisation, for example:
This does not cover data attributes are used on elements ‘within’ a component, like the
data-behaviour
attribute used on individual checkboxes within the checkboxes component.Relies on #2698.
Why
This aligns the general concept of 'component config' with the approach we're using for internationalisation.
Who needs to work on this
Developers
Who needs to review this
Developers
Done when
The text was updated successfully, but these errors were encountered: