Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how assistive technologies interact with character count #2539

Closed
4 tasks
dav-idc opened this issue Feb 9, 2022 · 6 comments
Closed
4 tasks

Comments

@dav-idc
Copy link

dav-idc commented Feb 9, 2022

What

We're looking to investigate how screen reader assistive technologies interact with the character count component.

https://design-system.service.gov.uk/components/character-count/
https://govuk-frontend-review.herokuapp.com/components/character-count

The investigation will focus primarily on gathering information to help resolve four related bugs, listed below.

Related bug tickets

This investigation will help us understand the bugs listed in the four tickets below.

Why

The character count component was initially designed to play well with screen readers, but sometime after the launch of the component something changed. Now there are four bugs that make interacting with the character count component via
a screen reader frustrating and cumbersome.

This might be an accessibility compliance issue, but more investigation would be needed to confirm. For now, we're approaching it as a severe usability issue and poor experience for those using a screen reader (and potentially other assistive technologies as well).

Who needs to work on this

  • @davidc-gds will handle the accessibility portions of the investigation and test with various browser and assistive technology combinations.
  • @owenatgov has offered to support from a developer perspective if capacity allows, since the character count component includes some JavaScript.

Who needs to review this

Unknown

Done when

  • Character count component variants are tested on various screen readers and browsers
  • Research is compiled into a summary
  • All 4 identified bugs have been explored
  • Action items and approaches are identified and proposed for each of the four identified bugs
@vanitabarrett vanitabarrett added 🔍 investigation and removed awaiting triage Needs triaging by team labels Feb 23, 2022
@querkmachine querkmachine self-assigned this Mar 16, 2022
querkmachine added a commit that referenced this issue Mar 21, 2022
Changes the character count to inject a new element that is
live updated, instead of overwriting the content of the initial
HTML hint.

This is intended to resolve an issue where screen readers are
reading out all elements referenced in aria-describedby for
each keystroke, and not just the updated counter element.

#2539
querkmachine added a commit that referenced this issue Mar 21, 2022
Changes the character count to inject a new element that is
live updated, instead of overwriting the content of the initial
HTML hint.

This is intended to resolve an issue where screen readers are
reading out all elements referenced in aria-describedby for
each keystroke, and not just the updated counter element.

#2539
querkmachine added a commit that referenced this issue Mar 22, 2022
Changes the character count to inject a new element that is
live updated, instead of overwriting the content of the initial
HTML hint.

This is intended to resolve an issue where screen readers are
reading out all elements referenced in aria-describedby for
each keystroke, and not just the updated counter element.

#2539
@owenatgov owenatgov removed their assignment Mar 30, 2022
querkmachine added a commit that referenced this issue Mar 31, 2022
Changes the character count to inject a new element that is
live updated, instead of overwriting the content of the initial
HTML hint.

This is intended to resolve an issue where screen readers are
reading out all elements referenced in aria-describedby for
each keystroke, and not just the updated counter element.

#2539
querkmachine added a commit that referenced this issue Apr 8, 2022
Changes the character count to inject a new element that is
live updated, instead of overwriting the content of the initial
HTML hint.

This is intended to resolve an issue where screen readers are
reading out all elements referenced in aria-describedby for
each keystroke, and not just the updated counter element.

#2539
@36degrees
Copy link
Contributor

@davidc-gds @querkmachine is there anything else to do here or can we call this one done?

@querkmachine
Copy link
Member

@36degrees We're still waiting on the guidance in the design system to be updated to reflect the changes made. We kept this issue open to accommodate for that but having a new issue in that repo might make more sense? @davidc-gds

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Apr 25, 2022

@querkmachine A new issue in the Design System repo would make sense to me - we could attach it to the v4.1.0 milestone in that repo then too

@dav-idc
Copy link
Author

dav-idc commented Apr 25, 2022

I'll see if I can set up a new ticket for the content updates @querkmachine (I'm quite confident I can)

@dav-idc
Copy link
Author

dav-idc commented Apr 25, 2022

I've set up the new issue for the guidance content updates. Feel free to edit or modify it if I've built it incorrectly:
alphagov/govuk-design-system#2155

@querkmachine would this mean that this issue can now be closed, and we'll hop over to that new issue?

@querkmachine
Copy link
Member

Sounds like a plan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants