Enable new link styles by default #2350
Comments
|
Note that we also opted-out the footer links separately 8187b57, because these often can have a multi-column layout, and we don't want sites using the new link styles to have broken footers. This does mean however that footer links currently don't have a clear hover state. |
|
It looks like the issue in #2204 has been fixed in Chrome 102, so we should consider this for the 5.0 release. |
github-project-automation
bot
moved this to Backlog 🗄
in GOV.UK Design System cycle board
36degrees
moved this from Backlog 🗄
to In progress 📝
in GOV.UK Design System cycle board
36degrees
added a commit
that referenced
this issue
May 10, 2023
In July 2021, we made some improvements to new link styles [1] which were released as part of v3.12.0. We introduced these changes behind a feature flag `$govuk-new-link-styles: true` which service teams needed to set before importing GOV.UK Frontend in order to opt-in. This was in case users: - needed to make changes to their service to introduce these new link styles consistently - wanted to avoid opting in if they have links within a multiple-column layout in your CSS, due to Known issue: hover state is mis-painted on links within CSS multiple-column layouts #2204 Now that #2204 has been fixed in Chromium, we can make the new link styles ‘opt-out’. [1]: #2350
36degrees
added a commit
that referenced
this issue
May 10, 2023
In July 2021, we made some improvements to new link styles [1] which were released as part of v3.12.0. We introduced these changes behind a feature flag `$govuk-new-link-styles: true` which service teams needed to set before importing GOV.UK Frontend in order to opt-in. This was in case users: - needed to make changes to their service to introduce these new link styles consistently - wanted to avoid opting in if they have links within a multiple-column layout in your CSS, due to Known issue: hover state is mis-painted on links within CSS multiple-column layouts #2204 Now that #2204 has been fixed in Chromium, we can make the new link styles ‘opt-out’. [1]: #2350
colinrotherham
moved this from In progress 📝
to Ready to release 🚀
in GOV.UK Design System cycle board
romaricpascal
pushed a commit
that referenced
this issue
May 18, 2023
In July 2021, we made some improvements to new link styles [1] which were released as part of v3.12.0. We introduced these changes behind a feature flag `$govuk-new-link-styles: true` which service teams needed to set before importing GOV.UK Frontend in order to opt-in. This was in case users: - needed to make changes to their service to introduce these new link styles consistently - wanted to avoid opting in if they have links within a multiple-column layout in your CSS, due to Known issue: hover state is mis-painted on links within CSS multiple-column layouts #2204 Now that #2204 has been fixed in Chromium, we can make the new link styles ‘opt-out’. [1]: #2350
36degrees
moved this from Ready to release 🚀
to Done 🏁
in GOV.UK Design System cycle board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In July 2021, we made some improvements to new link styles which were released as part of v3.12.0:
We introduced these changes behind a feature flag
$govuk-new-link-styles: truewhich service teams needed to set before importing GOV.UK Frontend in order to opt-in.This was in case users:
Now that #2204 has been fixed in Chromium, we should change the setting to enable the links, making the new link styles opt-out.
We may then choose to deprecate the flag for removal in a following major release.
What
Set
$govuk-new-link-stylestotrueingovuk/settings/_links.scss.Update any associated comments, documentation or tests.
Why
We want to encourage as many services as possible to use the new link styles. We decided to make the link styles opt-in because of #2204.
Who needs to know about this
Developers, tech writer
Done when
The text was updated successfully, but these errors were encountered: