Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small accordion design adjustments #2324

Closed
1 task
Tracked by #1706
hannalaakso opened this issue Aug 19, 2021 · 1 comment
Closed
1 task
Tracked by #1706

Small accordion design adjustments #2324

hannalaakso opened this issue Aug 19, 2021 · 1 comment
Assignees
@hannalaakso
Labels
accordion 🕔 hours A well understood issue which we expect to take less than a day to resolve.

Comments

@hannalaakso
Copy link
Member

hannalaakso commented Aug 19, 2021 •
edited
Loading

What

After reviewing the accordion with @christopherthomasdesign and some feedback from GOV.UK, we're going to:

  • add 25px bottom padding to the section buttons
  • add 5px space between heading, summary and button, instead of having the elements quite tightly packed as they are currently (see current behaviour in the screenshot)
    Screenshot 2021-08-19 at 18 36 39

Why

To follow our and GOV.UK Design conventions

Who needs to know about this

Developer

Done when

  • Thing to do
@hannalaakso hannalaakso added awaiting triage Needs triaging by team accordion labels Aug 19, 2021
@hannalaakso hannalaakso self-assigned this Aug 19, 2021
hannalaakso added a commit that referenced this issue Aug 24, 2021
@hannalaakso
WIP Small design adjustments
bc4387f 
Increase bottom padding on buttons as discussed in #2324

Still need to add more spacing between the elements inside the button on mobile.
@hannalaakso hannalaakso mentioned this issue Aug 25, 2021
Closed
62 tasks
vanitabarrett pushed a commit that referenced this issue Sep 22, 2021
@hannalaakso
WIP Small design adjustments
1450eef 
Increase bottom padding on buttons as discussed in #2324

Still need to add more spacing between the elements inside the button on mobile.
@vanitabarrett vanitabarrett added 🕔 hours A well understood issue which we expect to take less than a day to resolve. and removed awaiting triage Needs triaging by team labels Sep 24, 2021
hannalaakso added a commit that referenced this issue Sep 27, 2021
@hannalaakso
Small design adjustments
24b8219 
Increase bottom padding on buttons to 25px. Note that we only need 15px padding here, as another 10px comes from the invisible bottom border that improves high contrast mode presentation.

Add more spacing between the elements inside the button on mobile.

Fixes #2324
@hannalaakso
Copy link
Member Author

@christopherthomasdesign has kindly reviewed the design and thinks it looks okay (with the exception of #2371) so closing this.

hannalaakso added a commit that referenced this issue Oct 5, 2021
@hannalaakso
Small design adjustments
63f6dce 
Increase bottom padding on buttons to 25px. Note that we only need 15px padding here, as another 10px comes from the invisible bottom border that improves high contrast mode presentation.

Add more spacing between the elements inside the button on mobile.

Fix alignment of IE8 show/hide icon.

Fixes #2324
hannalaakso added a commit that referenced this issue Oct 13, 2021
@hannalaakso
Small design adjustments
eddab9a 
Increase bottom padding on buttons to 25px. Note that we only need 15px padding here, as another 10px comes from the invisible bottom border that improves high contrast mode presentation.

Add more spacing between the elements inside the button on mobile.

Fix alignment of IE8 show/hide icon.

Fixes #2324
hannalaakso added a commit that referenced this issue Oct 13, 2021
@hannalaakso
Small design adjustments
04fb3e1 
Increase bottom padding on buttons to 25px. Note that we only need 15px padding here, as another 10px comes from the invisible bottom border that improves high contrast mode presentation.

Add more spacing between the elements inside the button on mobile.

Fix alignment of IE8 show/hide icon.

Fixes #2324
hannalaakso added a commit that referenced this issue Oct 27, 2021
@hannalaakso
Align with GOV.UK design
7c8a00f 
Some small adjustments to align with GOV.UK design.

Increase bottom padding on buttons to 25px. Note that we only need 15px padding here, as another 10px comes from the invisible bottom border that improves high contrast mode presentation.

Add more spacing between the elements inside the button on mobile.

Increase padding below the 'Show' on tablet/desktop to about 30px. On mobile it should be about 20px.

Also fix alignment of IE8 show/hide icon.

Fixes #2324
hannalaakso added a commit that referenced this issue Nov 1, 2021
@hannalaakso
Align with GOV.UK design
496d1b0 
Some small adjustments to align with GOV.UK design.

Increase bottom padding on buttons to 25px. Note that we only need 15px padding here, as another 10px comes from the invisible bottom border that improves high contrast mode presentation.

Add more spacing between the elements inside the button on mobile.

Increase padding below the 'Show' on tablet/desktop to about 30px. On mobile it should be about 20px.

Also fix alignment of IE8 show/hide icon.

Fixes #2324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannalaakso hannalaakso

Labels
accordion 🕔 hours A well understood issue which we expect to take less than a day to resolve.
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hannalaakso @vanitabarrett