Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing space before CSS class #1630

Closed
dabd opened this issue Nov 5, 2019 · 0 comments · Fixed by #1631
Closed

Missing space before CSS class #1630

dabd opened this issue Nov 5, 2019 · 0 comments · Fixed by #1631
Assignees
@36degrees
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) character count
Milestone
v3.4.0

Comments

@dabd
Copy link

dabd commented Nov 5, 2019

The following https://github.com/alphagov/govuk-frontend/blob/master/src/govuk/components/character-count/template.njk#L14 is missing a space before the (params.classes if params.classes).
@NickColley NickColley added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) awaiting triage Needs triaging by team labels Nov 5, 2019
@36degrees 36degrees self-assigned this Nov 6, 2019
@36degrees 36degrees removed the awaiting triage Needs triaging by team label Nov 6, 2019
36degrees added a commit that referenced this issue Nov 6, 2019
@36degrees
Fix classes on character count when in error state
58cc438 
The template correctly adds whitespace between classnames when either the `—error` modifier is added or when custom classes are added, but not when both are added.

This means for example that if you were passing the custom class `app-character-count--custom-modifier` to the character count component whilst it was in an error state, the resulting class attribute would be `govuk-js-character-count govuk-textarea--errorapp-character-count--custom-modifier` – neither the error styling nor the custom class would be correctly applied.

Fixes #1630
@36degrees 36degrees mentioned this issue Nov 6, 2019
Merged
36degrees added a commit that referenced this issue Nov 6, 2019
@36degrees
Fix classes on character count when in error state
1e1d5c2 
The template correctly adds whitespace between classnames when either the `—error` modifier is added or when custom classes are added, but not when both are added.

This means for example that if you were passing the custom class `app-character-count--custom-modifier` to the character count component whilst it was in an error state, the resulting class attribute would be `govuk-js-character-count govuk-textarea--errorapp-character-count--custom-modifier` – neither the error styling nor the custom class would be correctly applied.

Fixes #1630
@dabd dabd mentioned this issue Nov 6, 2019
Closed
@36degrees 36degrees added this to the Next milestone Nov 7, 2019
m-green pushed a commit that referenced this issue Nov 13, 2019
@36degrees @m-green
Fix classes on character count when in error state
5845391 
The template correctly adds whitespace between classnames when either the `—error` modifier is added or when custom classes are added, but not when both are added.

This means for example that if you were passing the custom class `app-character-count--custom-modifier` to the character count component whilst it was in an error state, the resulting class attribute would be `govuk-js-character-count govuk-textarea--errorapp-character-count--custom-modifier` – neither the error styling nor the custom class would be correctly applied.

Fixes #1630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@36degrees 36degrees

Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) character count
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v3.4.0
Development

Successfully merging a pull request may close this issue.

Fix classes on character count when in error state alphagov/govuk-frontend
3 participants
@36degrees @dabd @NickColley