Header component script is not compatible with govuk_template #1270
Assignees
Labels
breaking change
🐛 bug
Something isn't working the way it should (including incorrect wording in documentation)
🕔 hours
A well understood issue which we expect to take less than a day to resolve.
Milestone
Comments
kellylee-gds
added
awaiting triage
alex-ju
added a commit
to alphagov/govuk_publishing_components
that referenced
this issue
Apr 15, 2019
This mitigates an issue when we use js-header-toggle for both menu buttons coming from govuk_template (which are marked-up with <a>) and for headers coming from govuk-frontend (marked-up with <button>) (alphagov/govuk-frontend#1270)
alex-ju
added a commit
to alphagov/govuk_publishing_components
that referenced
this issue
Apr 15, 2019
This mitigates an issue when we use js-header-toggle for both menu buttons coming from govuk_template (which are marked-up with <a>) and for headers coming from govuk-frontend (marked-up with <button>) (alphagov/govuk-frontend#1270)
alex-ju
added a commit
to alphagov/govuk_publishing_components
that referenced
this issue
Apr 15, 2019
This mitigates an issue when we use js-header-toggle for both menu buttons coming from govuk_template (which are marked-up with <a>) and for headers coming from govuk-frontend (marked-up with <button>) (alphagov/govuk-frontend#1270)
kellylee-gds
added
breaking change
🐛 bug
|
Adding this to the 3.0.0 milestone as a point of discussion, potentially we should be reviewing more than just this class and considering if they should be using a 'js-govuk' prefix. |
34 tasks
hannalaakso
added a commit
that referenced
this issue
May 23, 2019
This will allow us to test compatibility with GOV.UK Frontend scripts and to diagnose issues such as #1270 Co-authored-by: Nick Colley <[email protected]>
hannalaakso
added a commit
that referenced
this issue
May 24, 2019
This will allow us to test compatibility with GOV.UK Frontend scripts and to diagnose issues such as #1270 Co-authored-by: Nick Colley <[email protected]>
|
We have decided to change our uses of 'js-' to be 'govuk-js-' as per @hannalaakso 's suggestion. |
kellylee-gds
added
🕔 hours
|
Should be fixed in v3.0.0. Closing this as #1444 has been merged. |
aliuk2012
pushed a commit
that referenced
this issue
Jun 14, 2019
This will allow us to test compatibility with GOV.UK Frontend scripts and to diagnose issues such as #1270 Co-authored-by: Nick Colley <[email protected]>
aliuk2012
pushed a commit
that referenced
this issue
Jun 14, 2019
This will allow us to test compatibility with GOV.UK Frontend scripts and to diagnose issues such as #1270 Co-authored-by: Nick Colley <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
govuk_template has an IIFE for header navigation toggle which adds functionality to elements that have a
.js-header-toggleclass attached to it.The header component in govuk-frontend uses the same
.js-header-toggleclass (applied to a button element) to toggle the header.Problem
Because the govuk_template script is expecting an anchor instead of a button, it tries to get the
hrefattribute and fails to do so if the header component from govuk-frontend is used.Potential solution
Prefix or change
js-classes to avoid clashed with other scripts (including the deprecated ones).I'm happy to raise a PR myself since I think I introduced this bit of code, but I need a decision at the team level on what the solution should be.
The text was updated successfully, but these errors were encountered: