Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion non-js spacing on headers #1130

Closed
dankmitchell opened this issue Jan 14, 2019 · 1 comment · Fixed by #1149
Closed

Accordion non-js spacing on headers #1130

dankmitchell opened this issue Jan 14, 2019 · 1 comment · Fixed by #1149
Assignees
@aliuk2012
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@dankmitchell
Copy link

When disabling JS for an accordion; example - https://design-system.service.gov.uk/components/accordion/default/index.html

The spacing between the header and border is lost -

screen shot 2019-01-14 at 11 14 05
@NickColley
Copy link
Contributor

I wonder if we should have borders too, @dashouse what do you think?

@NickColley NickColley added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label Jan 14, 2019
@aliuk2012 aliuk2012 self-assigned this Jan 17, 2019
aliuk2012 added a commit that referenced this issue Jan 18, 2019
@aliuk2012
Fixes up styling of accordion when there is no js
e8fcb40 
fixes #1130
@aliuk2012 aliuk2012 mentioned this issue Jan 18, 2019
Merged
aliuk2012 added a commit that referenced this issue Jan 18, 2019
@aliuk2012
Fixes up styling of accordion when there is no js
14e3530 
fixes #1130
aliuk2012 added a commit that referenced this issue Jan 18, 2019
@aliuk2012
Fixes up styling of accordion when there is no js
9df0ac4 
fixes #1130
This was referenced Jan 31, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aliuk2012 aliuk2012

Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes styling of accordion when there is no js alphagov/govuk-frontend
3 participants
@NickColley @dankmitchell @aliuk2012