Remove appending hash behaviour when error summary link clicked (#1435)

Remove appending hash behaviour when error summary link clicked

CHANGELOG.md

@@ -270,6 +270,12 @@
 
 🔧 Fixes:
 
+- Stop appending hash when error summary link clicked
+
+  This prevents incorrectly focusing the form element with the hash id, instead of the error summary, when form is re-submitted with the hash in the URL and there are further errors.
+
+  ([PR #1435](https://github.com/alphagov/govuk-frontend/pull/1435))
+
 - Fix settings layer being implicitly dependant on itself.
 
   ([PR #1381](https://github.com/alphagov/govuk-frontend/pull/1381))

src/components/error-summary/error-summary.js

@@ -63,16 +63,6 @@ ErrorSummary.prototype.focusTarget = function ($target) {
     return false
   }
 
-  // Prefer using the history API where possible, as updating
-  // window.location.hash causes the viewport to jump to the input briefly
-  // before then scrolling to the label/legend in IE10, IE11 and Edge (as tested
-  // in Edge 17).
-  if (window.history.pushState) {
-    window.history.pushState(null, null, '#' + inputId)
-  } else {
-    window.location.hash = inputId
-  }
-
   // Scroll the legend or label into view *before* calling focus on the input to
   // avoid extra scrolling in browsers that don't support `preventScroll` (which
   // at time of writing is most of them...)

src/components/error-summary/error-summary.test.js

@@ -47,9 +47,9 @@ describe('Error Summary', () => {
       expect(legendOrLabelOffsetFromTop).toEqual(0)
     })
 
-    it('updates the hash in the URL', async () => {
+    it('does not include a hash in the URL', async () => {
       const hash = await page.evaluate(() => window.location.hash)
-      expect(hash).toBe(`#${inputId}`)
+      expect(hash).toBe('')
     })
   })
 })