Skip to content

Commit

Permalink
Revert removing the summary ID from accordion template
Browse files Browse the repository at this point in the history
We originally intended to remove the ID from the template markup as it's no longer required by `aria-describedby` in the accordion section header.

Revert that change since we've decided not to ask teams to make this breaking change yet. We want to wait to see if we receive any
feedback from teams regarding the issue flagged in https://design-system.service.gov.uk/components/accordion/#known-issues-and-gaps
(refer to https://deploy-preview-1961--govuk-design-system-preview.netlify.app/components/accordion/#known-issues-and-gaps
until we publish the v4 guidance in the Design System).
  • Loading branch information
hannalaakso committed Nov 1, 2021
1 parent e30bb92 commit c6dbd91
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/govuk/components/accordion/template.njk
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
</span>
</h{{ headingLevel }}>
{% if item.summary.html or item.summary.text %}
<div class="govuk-accordion__section-summary govuk-body">
<div class="govuk-accordion__section-summary govuk-body" id="{{ id }}-summary-{{ loop.index }}">
{{ item.summary.html | safe if item.summary.html else item.summary.text }}
</div>
{% endif %}
Expand Down

0 comments on commit c6dbd91

Please sign in to comment.