Skip to content

Commit

Permalink
Remove Checkboxes rule aria-allowed-attr
Browse files Browse the repository at this point in the history
Axe v4.8 now allows checkbox input `aria-expanded` from ARIA 1.2

dequelabs/axe-core#3343 (comment)
  • Loading branch information
colinrotherham committed Oct 17, 2023
1 parent 85b348e commit ae52d61
Showing 1 changed file with 1 addition and 14 deletions.
15 changes: 1 addition & 14 deletions src/govuk/components/checkboxes/accessibility.puppeteer.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,6 @@ import { axe, goToComponent } from '@govuk-frontend/helpers/puppeteer'
import { getExamples } from '@govuk-frontend/lib/components'

describe('/components/checkboxes', () => {
let axeRules

beforeAll(() => {
axeRules = {
/**
* Ignore 'ARIA attribute is not allowed: aria-expanded="false"'
*
* {@link https://github.com/alphagov/govuk-frontend/issues/979}
*/
'aria-allowed-attr': { enabled: false }
}
})

describe('component examples', () => {
let exampleNames

Expand All @@ -26,7 +13,7 @@ describe('/components/checkboxes', () => {
for (const exampleName of exampleNames) {
// Navigation to example, create report
await goToComponent(page, 'checkboxes', { exampleName })
await expect(axe(page, axeRules)).resolves.toHaveNoViolations()
await expect(axe(page)).resolves.toHaveNoViolations()
}
}, 120000)
})
Expand Down

0 comments on commit ae52d61

Please sign in to comment.