Replicate data from staging, not integration #763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the env sync was ported over to govuk-helm-charts, not all apps have backups saved to s3 on integration (e.g. note the lack of `backup` operation [here](https://github.com/alphagov/govuk-helm-charts/blob/cae5e10baf0f67423bbebf66454da737da787d37/charts/db-backup/values.yaml#L767-L773)). This means that the data replication scripts fail, as they're looking for a bucket that does not exist. In contrast, all data is backed up to s3 on staging, so it should be safe to pull from there by default. The only downside is that integration access is given to devs by default, but that access to staging and production required Production Admin access. This is something that can hopefully be ironed out in the move to using govuk-helm-charts for local development, over the coming months. For now it seems better to fix the script for prod-admin users than to have it broken for everyone. NB I've also removed the unnecessary duplication of replication examples where one used a readonly role and one used a poweruser role. We should use principle of least privilege, so only show the readonly example.
The 180m value was failing with: ``` $ gds aws govuk-production-poweruser --assume-role-ttl 180m ./bin/replicate-mysql.sh whitehall aws-vault: error: invalid input duration string, try --help ``` A bit of searching suggests that the maximum TTL is now 1 hour: 99designs/aws-vault#263
|
This feels like something that'll make it harder for any new starters and also creates an increased risk of sensitive data being on the dev machines given staging dbs aren't scrubbed. Can we not just fix the integration backups? Failing that could we have an env var of the environment that defaulted to integration, and if necessary, someone could change that to pull from staging/prod for a db backup (Is there a reason we'd actually want staging over prod?) |
ChrisBAshton
added a commit
to alphagov/govuk-helm-charts
that referenced
this pull request
Jul 24, 2024
What: Ensures that every application has its database data backed up to S3 in integration, for continued compatibility with govuk-docker. Why: Since the env sync was ported over to govuk-helm-charts, not all apps have backups saved to s3 on integration. This means that the data replication scripts in govuk-docker fail, as they're looking for a bucket that does not exist. Whilst we could configure govuk-docker to pull from production or staging instead (and indeed explored the idea in alphagov/govuk-docker#763), this has the downside of requiring that engineers have [Production Admin access](https://docs.publishing.service.gov.uk/manual/rules-for-getting-production-access.html#production-admin-access), so new starters would be unable to easily get production-like data for local development (new starters are only granted Integration Admin access).
|
Agreed. Superseded by alphagov/govuk-helm-charts#2200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the env sync was ported over to govuk-helm-charts, not all apps have backups saved to s3 on integration (e.g. note the lack of
backupoperation here). This means that the data replication scripts fail, as they're looking for a bucket that does not exist.In contrast, all data is backed up to s3 on staging, so it should be safe to pull from there by default. The only downside is that integration access is given to devs by default, but that access to staging and production required Production Admin access. This is something that can hopefully be ironed out in the move to using govuk-helm-charts for local development, over the coming months. For now it seems better to fix the script for prod-admin users than to have it broken for everyone.
NB I've also removed the unnecessary duplication of replication examples where one used a readonly role and one used a poweruser role. We should use principle of least privilege, so only show the readonly example.