Update search-admin config to reflect app changes
#745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `search-api` dependency - Remove environment variable for `database_cleaner` configuration (this gem has been removed as we're not using Cucumber anymore and RSpec system tests run in transactions so don't need it) - Change command in `app` stack to run conventional `bin/dev` that has been added to the application - Add explicit port to `app` stack now that the application is run through Foreman - Add `TEST_DATABASE_URL` to app stack to allow running tests on `app` stack too for convenience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search-apidependencydatabase_cleanerconfiguration (this gem has been removed as we're not using Cucumber anymore and RSpec system tests run in transactions so don't need it)appstack to run conventionalbin/devthat has been added to the applicationappstack now that the application is run through ForemanTEST_DATABASE_URLto app stack to allow running tests onappstack too for convenience