Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timed updates info in the global banner documentation #4716

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

KludgeKML
Copy link
Contributor

@KludgeKML KludgeKML commented Jul 2, 2024

Copy link
Contributor

@leenagupte leenagupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.

There's one typo, but that can be fixed without a re-review

@@ -26,6 +26,18 @@ In [`app/views/components/_global_bar.html.erb`]:
not disappear after being seen 3 times.
1. [Deploy Static]. See the [guidance on deploying Static](/manual/deploy-static.html).

### Timed Updates

If you now about banner changes in advance and need the updates to show at a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: should be "know" rather than "now"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed.

@KludgeKML KludgeKML force-pushed the timed-banner-updates branch from eb62413 to 303cd98 Compare July 2, 2024 12:30
@KludgeKML KludgeKML marked this pull request as ready for review July 3, 2024 16:03
@KludgeKML KludgeKML merged commit f1beff4 into main Jul 3, 2024
1 check passed
@KludgeKML KludgeKML deleted the timed-banner-updates branch July 3, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants