Fix mismatched <h2> </h3> in layout example #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview this change here: Built with commit e44b730 https://deploy-preview-842--govuk-design-system-preview.netlify.com |
richardTowers
commented
Apr 2, 2019
Discussed this with Alistair and we agreed that h2 would be better so we don't have a jump from h1 to h3. We also identified that the real issue was that the opening tag had been updated but not the closing tag which was the cause of the confusion between using h2 or h3.
aliuk2012
force-pushed
the
richardTowers-patch-1
branch
from
a7ae35c
to
e44b730
Compare
aliuk2012
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this came in by mistake in #784:
https://github.com/alphagov/govuk-design-system/pull/784/files#diff-7883ebc5245f0aeaea5ee02bb00d6d56L23