Roll back https://github.com/alphagov/govuk-design-system/pull/784 #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview this change here: Built with commit dc6c2c4 https://deploy-preview-809--govuk-design-system-preview.netlify.com |
hannalaakso
added a commit
that referenced
this pull request
Mar 4, 2019
This reverts a hotfix #809 that removed the changes in favour of a proper fix for #620 Generating example IDs from example titles can be brittle if there are unexpected characters in titles. Use slugger for more robust converting of exampleTitle to exampleId. This also uses the solution from #620 to fix duplicate IDs by adding an extra parameter "titleSuffix" to examples if necessary. Co-authored-by: Nick Colley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seem to have introduced a bug in #784 that produces invalid IDs for example markup.
Rolling the PR changes back as an initial fix.