Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more service navigation examples #4113

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

querkmachine
Copy link
Member

Adds a couple more examples of the service navigation component to the guidance page.

  • A 'default' example that has navigation links and no service name.
    • This is probably the most basic intended use of the component—as a navigational element.
    • All existing examples included a service name, but this made it less clear that element landmarks are different if there isn't a service name.
  • An example of the component alongside the GOV.UK header.
    • This shows how they're intended to be used together, as there were questions about whether the Service navigation should be within the <header> element or not.
    • This also visually demonstrates using the full-width border modifier class, which not all users were confident using from the written guidance.

@querkmachine querkmachine requested review from CharlotteDowns and a team September 3, 2024 17:15
@querkmachine querkmachine self-assigned this Sep 3, 2024
Copy link

netlify bot commented Sep 3, 2024

You can preview this change here:

Name Link
🔨 Latest commit 2ce79fa
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/66d7442bb806860008b565f1
😎 Deploy Preview https://deploy-preview-4113--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@CharlotteDowns CharlotteDowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ace! I guess we won't see the changes come through from Fix service navigation mobile toggle spacing alphagov/govuk-frontend#5278 until a new version is released of Frontend? Either way I don't think it's worth delaying.

Copy link
Contributor

@calvin-lau-sig7 calvin-lau-sig7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@querkmachine querkmachine merged commit fa8c258 into main Sep 4, 2024
15 checks passed
@querkmachine querkmachine deleted the service-navigation-examples branch September 4, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants