Add hyphen to mention of layout type #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EoinShaughnessy
added
the
documentation
EoinShaughnessy
commented
Dec 8, 2021
EoinShaughnessy
force-pushed
the
add-hyphen
branch
from
285ef48 to
407fe02
Compare
|
✔️ You can preview this change here: 🔨 Explore the source changes: 285ef48 🔍 Inspect the deploy log: https://app.netlify.com/sites/govuk-design-system-preview/deploys/61b0ca7896ae9d00084bf31d 😎 Browse the preview: https://deploy-preview-1995--govuk-design-system-preview.netlify.app |
|
✔️ You can preview this change here: 🔨 Explore the source changes: 407fe02 🔍 Inspect the deploy log: https://app.netlify.com/sites/govuk-design-system-preview/deploys/61b0cad0116cd700077dd6ac 😎 Browse the preview: https://deploy-preview-1995--govuk-design-system-preview.netlify.app |
|
Nice one! I thought we caught the last of these. |
calvin-lau-sig7
approved these changes
Dec 8, 2021
|
@calvin-lau-sig7 Ta for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big change, this one. 😛 Spotted a tiny inconsistency in the Layout guidance when I looked it up to help with reviewing a footer PR.