-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to GOV.UK Frontend v4.0.0 #1992
Conversation
I've updated the Design System to the current pre-release and gone through the GOV.UK Frontend Changelog to double check any changes that need to be made. I don't think any changes need to be made. Once all the changes are merged into GOV.UK Frontend, I'll generate a new pre-release and update to that one to cover the breaking changes merged in after the pre-release was shared with users on 07/12/2021 |
✔️ You can preview this change here: 🔨 Explore the source changes: 89a25d8 🔍 Inspect the deploy log: https://app.netlify.com/sites/govuk-design-system-preview/deploys/61bb056b60c6b200071d47bd 😎 Browse the preview: https://deploy-preview-1992--govuk-design-system-preview.netlify.app |
cb0157e
to
ec9e842
Compare
I've updated this to the latest pre-release which includes the footer changes. I don't expect any more changes to go into the release, other than a fix to the implementation of the skip link JavaScript. |
I think we need to initialise the skip link JavaScript in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses the header HTML in non-standard ways (using custom navigation that doesn't sit inside the header like it does for the component) - I'm not sure the changes we've made to the component can be applied directly to the design system implementation
As discussed irl, we'll raise a separate issue to investigate this later since it's not possible to directly apply the improvements to the Design System header.
The rest looks good 👍
Approving this now so it'll be ready to go when we've published GOV.UK Frontend v4.0, it shouldn't be merged until we've swapped the version number in the package lock.
0e03e68
to
4c37eef
Compare
Thanks @36degrees , good spot, I've added a commit to do that now |
We've made changes in GOV.UK Frontend v4.0.0 so that the JS now looks through the whole page rather than just within the module. This means we need to make sure the `id` for character counts on the same page are unique. I don't think this should be an issue as we put our examples within iframes, but it's good to be consistent
4c37eef
to
89a25d8
Compare
Closes #1851
Updates the Design System to use v4.0.0.
Note: the current PR updates the Design System to use the v4.0.0 pre-release. This PR will need to be updated for the actual release, to point to the version of GOV.UK Frontend published on
npm
.Things I've checked
The Design System:
govuk-main-wrapper
orgovuk-main-wrapper--l
mixins$govuk-border-width-form-element-error
variableiff
Sass functiongovuk-tag--inactive
classcore
oroverrides
aria-hidden="true"
for SVGs in the headerI've added commits to:
id
swidth
macro option to any footer components that need it