Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GOV.UK Frontend v4.0.0 #1992

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Update to GOV.UK Frontend v4.0.0 #1992

merged 4 commits into from
Dec 16, 2021

Conversation

vanitabarrett
Copy link
Contributor

@vanitabarrett vanitabarrett commented Dec 7, 2021

Closes #1851

Updates the Design System to use v4.0.0.

Note: the current PR updates the Design System to use the v4.0.0 pre-release. This PR will need to be updated for the actual release, to point to the version of GOV.UK Frontend published on npm.

Things I've checked

The Design System:

  • does not use the govuk-main-wrapper or govuk-main-wrapper--l mixins
  • does not use the $govuk-border-width-form-element-error variable
  • does not individually import JavaScript files
  • does not use HTML error messages
  • does not use HTML hints
  • does not use HTML skip link
  • does not use iff Sass function
  • does not use govuk-tag--inactive class
  • does not import individual Sass files from core or overrides
  • does not use HTML date input
  • does not use the HTML cookie banner
  • already uses aria-hidden="true" for SVGs in the header
  • already styles custom HTML being passed to the cookie banner component
  • already uses conditional reveals with unique id's per page
  • uses the header HTML in non-standard ways (using custom navigation that doesn't sit inside the header like it does for the component) - I'm not sure the changes we've made to the component can be applied directly to the design system implementation
  • has a PR raised to update the summary list guidance (Add a summary list example where only some rows have actions #1990)
  • has a PR raised to update the accessibility statement for accordions (Delete accordion issue in accessibility statement #1825)
  • has a PR raised to update the accordion guidance and examples for the new iteration (Update accordion guidance for v4.0.0 #1961)

I've added commits to:

  • ensure character counts use unique ids
  • add the width macro option to any footer components that need it

@vanitabarrett
Copy link
Contributor Author

I've updated the Design System to the current pre-release and gone through the GOV.UK Frontend Changelog to double check any changes that need to be made. I don't think any changes need to be made.

Once all the changes are merged into GOV.UK Frontend, I'll generate a new pre-release and update to that one to cover the breaking changes merged in after the pre-release was shared with users on 07/12/2021

@vanitabarrett vanitabarrett changed the title [WIP] Update to GOV.UK Frontend v4.0.0 [DO NOT MERGE][WIP] Update to GOV.UK Frontend v4.0.0 Dec 7, 2021
@netlify
Copy link

netlify bot commented Dec 7, 2021

✔️ You can preview this change here:

🔨 Explore the source changes: 89a25d8

🔍 Inspect the deploy log: https://app.netlify.com/sites/govuk-design-system-preview/deploys/61bb056b60c6b200071d47bd

😎 Browse the preview: https://deploy-preview-1992--govuk-design-system-preview.netlify.app

@vanitabarrett vanitabarrett requested a review from a team December 9, 2021 15:26
@vanitabarrett
Copy link
Contributor Author

vanitabarrett commented Dec 9, 2021

I've updated this to the latest pre-release which includes the footer changes. I don't expect any more changes to go into the release, other than a fix to the implementation of the skip link JavaScript.

@36degrees
Copy link
Contributor

I think we need to initialise the skip link JavaScript in src/javascripts/govuk-frontend.js.

Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uses the header HTML in non-standard ways (using custom navigation that doesn't sit inside the header like it does for the component) - I'm not sure the changes we've made to the component can be applied directly to the design system implementation

As discussed irl, we'll raise a separate issue to investigate this later since it's not possible to directly apply the improvements to the Design System header.

The rest looks good 👍

Approving this now so it'll be ready to go when we've published GOV.UK Frontend v4.0, it shouldn't be merged until we've swapped the version number in the package lock.

@vanitabarrett
Copy link
Contributor Author

Thanks @36degrees , good spot, I've added a commit to do that now

Vanita Barrett added 4 commits December 16, 2021 09:17
We've made changes in GOV.UK Frontend v4.0.0 so that the JS now
looks through the whole page rather than just within the module.
This means we need to make sure the `id` for character counts on
the same page are unique.

I don't think this should be an issue as we put our examples within iframes,
but it's good to be consistent
@vanitabarrett vanitabarrett marked this pull request as ready for review December 16, 2021 09:24
@vanitabarrett vanitabarrett changed the title [DO NOT MERGE][WIP] Update to GOV.UK Frontend v4.0.0 Update to GOV.UK Frontend v4.0.0 Dec 16, 2021
@vanitabarrett vanitabarrett merged commit b1f5205 into main Dec 16, 2021
@vanitabarrett vanitabarrett deleted the update-to-v4.0.0 branch December 16, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Design System to use GOV.UK Frontend v4.0.0
3 participants