Update the Task list pattern #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not just the completed ones
To explicitly show incomplete tasks
|
You can preview this change here: Built with commit d7fbeb1 https://deploy-preview-1250--govuk-design-system-preview.netlify.app |
|
You can preview this change here: Built with commit 5cf3f58 https://deploy-preview-1250--govuk-design-system-preview.netlify.app |
36degrees
reviewed
Apr 29, 2020
joelanman
reviewed
Apr 29, 2020
And amend it to say that the summary should appear all the time.
6 tasks
These are based on an analysis of examples from the backlog, here: alphagov/govuk-design-system-backlog#72 (comment)
36degrees
added a commit
to alphagov/govuk-prototype-kit
that referenced
this pull request
May 28, 2020
We're updating the task list pattern in the Design System to make it clearer which tasks still need to be done [1]. This updates the template in the Prototype Kit so that it matches the examples used in the Design System. [1]: alphagov/govuk-design-system#1250
36degrees
added a commit
to alphagov/govuk-prototype-kit
that referenced
this pull request
May 28, 2020
We're updating the task list pattern in the Design System to make it clearer which tasks still need to be done [1]. This updates the template in the Prototype Kit so that it matches the examples used in the Design System. [1]: alphagov/govuk-design-system#1250
To include a 'Not started' example and remove links from tasks that the user cannot start yet
36degrees
added a commit
to alphagov/govuk-prototype-kit
that referenced
this pull request
Jun 4, 2020
We're updating the task list pattern in the Design System to make it clearer which tasks still need to be done [1]. This updates the template in the Prototype Kit so that it matches the examples used in the Design System. [1]: alphagov/govuk-design-system#1250
To reflect improvements, but also uncertainty regarding tasks that cannot be started yet
36degrees
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make incomplete tasks clearer to users.