Don't unneccesarily self-close tags #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're currently inconsistent as to whether we self-close void elements or not. The self-closing / has no effect on the start tags of void elements in HTML5.[1] For this reason, we should standardise on omitting them. [1]: https://html.spec.whatwg.org/dev/syntax.html#start-tags
|
You can preview this change here: Built with commit 995ed33 https://deploy-preview-1122--govuk-design-system-preview.netlify.com |
domoscargin
added a commit
that referenced
this pull request
Feb 15, 2023
The self-closing / has no effect on the start tags of void elements in HTML5. For this reason, we should standardise on omitting them. https://html.spec.whatwg.org/dev/syntax.html#start-tags #1122
domoscargin
added a commit
that referenced
this pull request
Feb 16, 2023
The self-closing / has no effect on the start tags of void elements in HTML5. For this reason, we should standardise on omitting them. https://html.spec.whatwg.org/dev/syntax.html#start-tags #1122
domoscargin
added a commit
that referenced
this pull request
Feb 20, 2023
The self-closing / has no effect on the start tags of void elements in HTML5. For this reason, we should standardise on omitting them. https://html.spec.whatwg.org/dev/syntax.html#start-tags #1122
domoscargin
added a commit
that referenced
this pull request
Feb 20, 2023
The self-closing / has no effect on the start tags of void elements in HTML5. For this reason, we should standardise on omitting them. https://html.spec.whatwg.org/dev/syntax.html#start-tags #1122
domoscargin
added a commit
that referenced
this pull request
Feb 22, 2023
The self-closing / has no effect on the start tags of void elements in HTML5. For this reason, we should standardise on omitting them. https://html.spec.whatwg.org/dev/syntax.html#start-tags #1122
domoscargin
added a commit
that referenced
this pull request
Feb 22, 2023
The self-closing / has no effect on the start tags of void elements in HTML5. For this reason, we should standardise on omitting them. https://html.spec.whatwg.org/dev/syntax.html#start-tags #1122
domoscargin
added a commit
that referenced
this pull request
Feb 22, 2023
The self-closing / has no effect on the start tags of void elements in HTML5. For this reason, we should standardise on omitting them. https://html.spec.whatwg.org/dev/syntax.html#start-tags #1122
domoscargin
added a commit
that referenced
this pull request
Feb 22, 2023
The self-closing / has no effect on the start tags of void elements in HTML5. For this reason, we should standardise on omitting them. https://html.spec.whatwg.org/dev/syntax.html#start-tags #1122
domoscargin
added a commit
that referenced
this pull request
Feb 22, 2023
The self-closing / has no effect on the start tags of void elements in HTML5. For this reason, we should standardise on omitting them. https://html.spec.whatwg.org/dev/syntax.html#start-tags #1122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently inconsistent as to whether we self-close void elements or not.
The self-closing / has no effect on the start tags of void elements in HTML5.1
For this reason, we should standardise on omitting them.