This repository has been archived by the owner on Nov 2, 2021. It is now read-only.
Add analytics to the accounts manager (part 2) #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shout if you want me to update detect secrets? |
Yes, please @huwd, that would be great as I struggle with setting it up. |
|
Done, there was also some linting, I've put them in separate commits so you can see the changes. |
|
Thank you! Will try and set the pre-commit up so I don't have to bother you next time. |
|
I can help with that too if it speeds things along, we took Owen through it last week |
alex-ju
force-pushed
the
more-analytics
branch
from
419b46a to
1741646
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up on #241 and adds custom events as requested in the Analytics for experiments document, rows 23-49.
Trello card