Incremented Kramdown #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the rationale? |
|
See the issue which references this PR. |
|
Ah. Gotcha. The build is failing with what seems to be related errors. |
|
I see, looks like some additional spacing at the end of a Is this space required functionality, or does the test need to be updated? |
|
Any update on this? |
|
@jacobtomlinson Kramdown stripping that whitespace seems reasonable to me. Can you fix up the specs given this new behaviour? |
|
@benlovell 👍 done |
|
Incase anyone needs to know what changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the minor version of Kramdown from
1.5.0to1.10.0.