Generator for adding formats #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage: `rails generate format [format_name]` Adds the following files: * View specific stylesheet (and appends include to application.scss) * Format erb template with title, page class, title component and description * Format presenter * Format presenter test * Format integration test
| source_root File.expand_path('../templates', __FILE__) | ||
|
|
||
| def copy_format_files | ||
| format_name = file_name |
There was a problem hiding this comment.
It'd be good to call underscore on this. Rails generators for e.g. model accept both forms and turn them into the correct thing, e.g. rails g model FooBar is equivalent to rails g model foo_bar.
There was a problem hiding this comment.
Good point, added in 5792915
Let both of these work correctly: bundle exec rails generate format format_name bundle exec rails generate format FormatName
|
👍 but will let @dsingleton look first and merge |
|
Nah, let's merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @dsingleton's work for components: alphagov/static#444
Usage:
rails generate format [format_name]Adds the following files:
description
Based around these early commits when adding formats: