Add page and order args to embedded content helper #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
force-pushed
the
content-modelling/678-add-new-args-to-embedded-content-helper
branch
6 times, most recently
from
2136b78 to
13cdd4a
Compare
csutter
approved these changes
Nov 14, 2024
I've added a new `stub_publishing_api_has_embedded_content_for_any_content_id` helper rather than checking if `content_id` is `anything`, because the way we match query strings when a url is a regex is slightly different.
pezholio
force-pushed
the
content-modelling/678-add-new-args-to-embedded-content-helper
branch
from
13cdd4a to
ae41716
Compare
pezholio
deleted the
content-modelling/678-add-new-args-to-embedded-content-helper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the
stub_publishing_api_has_embedded_contenthelper to allow us to mock requests with a query string. I've added a newstub_publishing_api_has_embedded_content_for_any_content_idhelper rather than checking ifcontent_idisanything, because the way we match query strings when a url is a regex is slightly different.