Remove specialist topics from email alert api Pact tests #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
changed the title
unoduetre
force-pushed
the
2422-remove-specialist-topic-code-from-email-alert-api-l
branch
2 times, most recently
from
af32105 to
34473a9
Compare
unoduetre
force-pushed
the
2422-remove-specialist-topic-code-from-email-alert-api-l
branch
2 times, most recently
from
40a8d72 to
53e0009
Compare
unoduetre
force-pushed
the
2422-remove-specialist-topic-code-from-email-alert-api-l
branch
2 times, most recently
from
f69edda to
d1b11d5
Compare
unoduetre
force-pushed
the
2422-remove-specialist-topic-code-from-email-alert-api-l
branch
from
d1b11d5 to
1e8004a
Compare
unoduetre
force-pushed
the
2422-remove-specialist-topic-code-from-email-alert-api-l
branch
from
1e8004a to
128c89a
Compare
This commit removes specialist topics related code from tests. It matches the changes introduced by the #2147 PR.
unoduetre
force-pushed
the
2422-remove-specialist-topic-code-from-email-alert-api-l
branch
from
128c89a to
0d4a054
Compare
unoduetre
deleted the
2422-remove-specialist-topic-code-from-email-alert-api-l
branch
|
By the way, given this was just a change to the pacts you didn't need to release a new version of this gem - the tests aren't even included so the released gem of this version is essentially identical code to the previous version of the gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
What
Remove specialist topics from Pact tests for email-alert-api.
Why
So the following email-alert-api PR tests can finish successfully.
Trello card