Guide print stylesheet: from gov.uk text duplicated #626
Conversation
|
" from GOV.UK" is currently being added at the end of all print titles as part of the core print CSS in static |
|
This looks good to me, but it might be worth getting a native welsh speaker in the office (Rhiannon) to double check the new strings make sense? |
camillebaldock
changed the title
|
DO NOT MERGE: currently undergoing product discussion over whether static should be adding "from GOV.UK" or not to the end of title |
|
I don't think we need product discussion on this change, as it's just removing the duplication in guides? I would like to get that second set of eyes from a native welsh speaker tho. Assuming that's fine then consider this a pre-emptive LGTM and merged when i18n approved. |
|
Product discussion with Roo Reynolds has concluded that we should remove both "a guide from gov.uk" from the print template, and stop adding "from gov.uk" to the print stylesheet (alphagov/static#428) |
camillebaldock
changed the title
Guide print stylesheet: from gov.uk text duplicated This fixes this issue: https://govuk.zendesk.com/agent/#/tickets/764799 When printing out a guide, the title is followed by "a guide from GOV.UK from GOV.UK" This change fixes that duplication. I will be opening a new pivotal ticket to track the issue that "from GOV.UK" is being added to the print copy even for Welsh print-outs: this is a less straightforward change as it ties in to another discussion on locales on HTML pages.
Remove "from gov.uk" on print stylesheet This fix stems from this issue: https://govuk.zendesk.com/agent/#/tickets/764799 which created inconsistencies like" https://www.gov.uk/lwfans-ceisio-gwaith/print (language inconsistency) and https://www.gov.uk/rent-room-in-your-home/print (duplication!) Roo Reynolds made the decision to remove both "a guide from gov.uk" from the print template, and stop adding "from gov.uk" to the print stylesheet: this fix together with a fix to frontend (alphagov/frontend#626) addresses that.
This fixes this issue:
https://govuk.zendesk.com/agent/#/tickets/764799
When printing out a guide, the title is followed by "a guide from GOV.UK from GOV.UK"
This change fixes that duplication.
I will be opening a new pivotal ticket to track the issue that "from GOV.UK" is being added to the print copy even for Welsh print-outs: this is a less straightforward change as it ties in to another discussion on locales on HTML pages.