Fix for select element while zoomed #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text in select box cut off while viewing at 200% text-only on Firefox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While zoomed-in-via-text-only on Firefox the text within the select box cut is off while viewing at 200%.
(This is in-part due to positioning elements being pixel based not relative)
Why
Ticket and can be seen on live
I've noticed this PR from 08/19 implemented the CSS fix and this PR builds on this. I'm aware this introduces a
gem-c-selectclass without the use of the actual gem for this element which is tech debt. However I'm also mindful this might be resolved within this Design System audit update ticket so as a temp solution this could be desirable - this PR could prompt a wider discussion.Visuals
Before
After
Merged changes are automatically deployed to staging and production.
Make sure you follow the guidance for deployments before you merge.
Check your branch is being deployed in the Release app, after merging.