Render the frequency question in a legend #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a govspeak component inside the legend of the form to inherit govspeak styles. We also apply a class to the header so that we can give this title a bottom margin. This also drops the second line "You can get updates about changes:" as having this in the legend made for a confusing screenreader experience.
This was referenced Feb 21, 2018
thomasleese
approved these changes
Feb 22, 2018
rubenarakelyan
approved these changes
Feb 22, 2018
fofr
approved these changes
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a govspeak component inside the legend of the form to inherit
govspeak styles. We also apply a class to the header so that we can give
this title a bottom margin.
This also drops the second line "You can get updates about changes:" as
having this in the legend made for a confusing screenreader experience.
Before:
After:
