Add learn-to-drive-a-car task list page #400

sihugh · 2017-10-27T08:00:07Z

This is reliant on the tasklist component in alphagov/static#1173, so to test this you will need to have a local static running on the create-tasklist-component branch until that is merged and deployed.

We will add Smokey tests to cover this behaviour similar to the tests for the accordion

This page is the first item in the public beta of task list pages run by the modelling-services team.

The content item for this page is manually published from collections-publisher

The json file recording the content is deep symbolized after parsing to facilitate working with components which use symbolized keys.

This page is expected to mostly replicate the prototype although some small differences are likely after design review of the tasklist component.

Somewhat to do with: https://trello.com/c/M8ZYKOF1/231-create-hardcoded-json-for-learning-to-drive-beta
but mostly: https://trello.com/c/nByQmGoZ/201-implement-tasklist-page-in-preparation-for-public-beta-rollout

Screenshots

Desktop

Mobile

andysellick · 2017-10-27T11:28:09Z

config/tasklists/learn-to-drive-a-car.json

+      [
+        {
+          "title": "Check you're allowed to drive",
+          "panel": "Most people can start learning to drive when they’re 17.",


You can use the 'panel' option here, but I'd recommend the 'panel_descriptions' as they're styled by the component, which means if we want to change how they look we can more easily do that. Panel descriptions are an array of strings, which get inserted into P tags, i.e.

panel_descriptions: [
"This is a panel description.",
"This is also a panel description. It has been filled with words such as CONTENT and ACCORDION in order to fill the horizontal space and wrap onto a second line."
]

Ah, good shout, thanks. I'll get these switched over and update the screenshots

andysellick · 2017-10-27T11:29:07Z

app/views/tasklist/show.html.erb

+</div>
+<div class="grid-row">
+  <div class="column-two-thirds">
+    <%= render "govuk_component/tasklist", @tasklist[:tasklist] %>


Davidslv · 2017-10-30T10:00:07Z

app/controllers/tasklist_controller.rb

@@ -0,0 +1,5 @@
+class TasklistController < ApplicationController
+  def show
+    @tasklist = TasklistContent.learn_to_drive_config


We should follow the convention implemented in other controllers, of not using instance variables

render :show, locals: { tasklist: TasklistContent.learn_to_drive_config }

I've changed it to match, thanks

Davidslv · 2017-10-30T11:12:00Z

config/routes.rb

@@ -6,6 +6,8 @@
  mount JasmineRails::Engine => '/specs' if defined?(JasmineRails)
  mount GovukPublishingComponents::Engine, at: "/component-guide" if defined?(GovukPublishingComponents)

+  get "learn-to-drive-a-car", to: 'tasklist#show'


I believe you missing / before the learn-to-drive-a-car

Good spot, thanks. It miraculously works either way though :-D

Davidslv · 2017-10-31T12:25:32Z

test/integration/tasklist_page_test.rb

+  end
+
+  def tasklist_step_keys(tasklist_args)
+    tasklist_args[:steps].flatten.map(&:keys).flatten.uniq


you can use flat_map

Nice, thanks

This will help catch linting errors before they are flagged up by CI.

This page is the first item in the public beta of task list pages run by the modelling-services team. The content item for this page is [manually published from collections-publisher](alphagov/collections-publisher#250) The json file recording the content is deep symbolized to facilitate working with components which use symbolized keys. This page is expected to replicate [the prototype](https://govuk-services-prototype.herokuapp.com/services/learn-to-drive-a-car)

sihugh · 2017-11-01T14:10:39Z

This is now ready for merging.

tijmenb temporarily deployed to govuk-collections-pr-400 October 27, 2017 08:00 Inactive

sihugh force-pushed the add-tasklist-page branch from 907e190 to d0abb7c Compare October 27, 2017 08:58

tijmenb temporarily deployed to govuk-collections-pr-400 October 27, 2017 08:58 Inactive

sihugh force-pushed the add-tasklist-page branch from d0abb7c to 7e7a5e8 Compare October 27, 2017 09:03

tijmenb temporarily deployed to govuk-collections-pr-400 October 27, 2017 09:03 Inactive

sihugh mentioned this pull request Oct 27, 2017

Add link for "Learn to drive a car: step by step" page into /browse #397

Merged

tijmenb temporarily deployed to govuk-collections-pr-400 October 27, 2017 09:38 Inactive

andysellick reviewed Oct 27, 2017

View reviewed changes

sihugh force-pushed the add-tasklist-page branch from 322ea3f to dd3ec70 Compare October 27, 2017 15:23

tijmenb temporarily deployed to govuk-collections-pr-400 October 27, 2017 15:23 Inactive

sihugh force-pushed the add-tasklist-page branch from dd3ec70 to 37e56de Compare October 27, 2017 15:27

tijmenb temporarily deployed to govuk-collections-pr-400 October 27, 2017 15:27 Inactive

Davidslv reviewed Oct 30, 2017

View reviewed changes

sihugh force-pushed the add-tasklist-page branch from 37e56de to 9f164da Compare October 30, 2017 13:26

tijmenb temporarily deployed to govuk-collections-pr-400 October 30, 2017 13:26 Inactive

sihugh force-pushed the add-tasklist-page branch from 9f164da to a75d4f9 Compare October 30, 2017 13:30

tijmenb temporarily deployed to govuk-collections-pr-400 October 30, 2017 13:30 Inactive

sihugh changed the title ~~[DO NOT MERGE] Add learn-to-drive-a-car task list page~~ Add learn-to-drive-a-car task list page Oct 31, 2017

Davidslv reviewed Oct 31, 2017

View reviewed changes

sihugh force-pushed the add-tasklist-page branch from a75d4f9 to 2c639dd Compare October 31, 2017 14:45

tijmenb temporarily deployed to govuk-collections-pr-400 October 31, 2017 14:45 Inactive

sihugh force-pushed the add-tasklist-page branch from 2c639dd to 6eb23cd Compare November 1, 2017 11:23

tijmenb temporarily deployed to govuk-collections-pr-400 November 1, 2017 11:23 Inactive

Add linter to default rake task

adf0982

This will help catch linting errors before they are flagged up by CI.

sihugh force-pushed the add-tasklist-page branch from 6eb23cd to fed764c Compare November 1, 2017 13:31

tijmenb temporarily deployed to govuk-collections-pr-400 November 1, 2017 13:32 Inactive

sihugh force-pushed the add-tasklist-page branch from fed764c to 22826be Compare November 1, 2017 13:55

tijmenb deployed to govuk-collections-pr-400 November 1, 2017 13:55 View deployment

andysellick approved these changes Nov 1, 2017

View reviewed changes

sihugh merged commit 7533dd8 into master Nov 1, 2017

sihugh deleted the add-tasklist-page branch November 1, 2017 15:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add learn-to-drive-a-car task list page #400

Add learn-to-drive-a-car task list page #400

sihugh commented Oct 27, 2017 •

edited

Loading

andysellick Oct 27, 2017

sihugh Oct 27, 2017

andysellick Oct 27, 2017

Davidslv Oct 30, 2017

sihugh Oct 30, 2017

Davidslv Oct 30, 2017

sihugh Oct 30, 2017

Davidslv Oct 31, 2017

sihugh Oct 31, 2017

sihugh commented Nov 1, 2017

Add learn-to-drive-a-car task list page #400

Add learn-to-drive-a-car task list page #400

Conversation

sihugh commented Oct 27, 2017 • edited Loading

Screenshots

Desktop

Mobile

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sihugh commented Nov 1, 2017

sihugh commented Oct 27, 2017 •

edited

Loading