Update tracking on accordions #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ahead of a change to how tracking and accordion tracking works, update accordions to have the simpler `ga4_tracking:true` option instead of passing multiple data attributes
andysellick
changed the title
AshGDS
approved these changes
Nov 29, 2022
andysellick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE this change unless it also includes a new version of the components gem with the mentioned change below
Follow these steps if you are doing a Rails upgrade.
What
ga4_tracking:trueoption instead of passing multiple data attributesPages that this occurs on:
Why
We've been changing how tracking works a little, specifically in alphagov/govuk_publishing_components#3082 and this PR updates to take account of that change.
Visual changes
None.
Trello card: https://trello.com/c/LIhvDkyC/279-simplify-adding-ga4-tracking-to-accordions