Remove button html from API response #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API endpoint is only used by the single page notification button component in the gem [1]. The gem has been updated to expect a different response [2]. 1 https://github.com/search?q=org%3Aalphagov+check-email-subscription&type=code 2 alphagov/govuk_publishing_components#3071
chao-xian
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove button html from API response
Why
So that it's possible to update the text of the single page notification button component without making changes to this API.
This API endpoint is only used by the single page notification button component in the gem, see here. The gem has been updated to expect a different response, see here.
https://trello.com/c/gpch42Uc/1456-support-custom-button-text-on-the-single-page-notification-button-l