Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-govuk from 3.16.0 to 3.17.0 #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,7 @@ inherit_mode:
# This is not supported for Mongoid
Rails/FindBy:
Enabled: false

Rails/SaveBang:
AllowedReceivers:
- indices # for elasticsearch
28 changes: 14 additions & 14 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ GEM
addressable (2.7.0)
public_suffix (>= 2.0.2, < 5.0)
arel (9.0.0)
ast (2.4.0)
ast (2.4.1)
brakeman (4.7.1)
bson (4.9.1)
builder (3.2.4)
Expand Down Expand Up @@ -123,7 +123,7 @@ GEM
http-accept (1.7.0)
http-cookie (1.0.3)
domain_name (~> 0.5)
i18n (1.8.3)
i18n (1.8.4)
concurrent-ruby (~> 1.0)
json (2.3.0)
json-schema (2.8.0)
Expand Down Expand Up @@ -170,9 +170,9 @@ GEM
nokogiri (1.10.10)
mini_portile2 (~> 2.4.0)
null_logger (0.0.1)
parallel (1.19.1)
parser (2.7.1.3)
ast (~> 2.4.0)
parallel (1.19.2)
parser (2.7.1.4)
ast (~> 2.4.1)
plek (4.0.0)
pry (0.12.2)
coderay (~> 1.1.0)
Expand Down Expand Up @@ -248,30 +248,30 @@ GEM
rspec-mocks (~> 3.9)
rspec-support (~> 3.9)
rspec-support (3.9.3)
rubocop (0.85.1)
rubocop (0.87.1)
parallel (~> 1.10)
parser (>= 2.7.0.1)
parser (>= 2.7.1.1)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.7)
rexml
rubocop-ast (>= 0.0.3)
rubocop-ast (>= 0.1.0, < 1.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 2.0)
rubocop-ast (0.0.3)
rubocop-ast (0.2.0)
parser (>= 2.7.0.1)
rubocop-govuk (3.16.0)
rubocop (= 0.85.1)
rubocop-govuk (3.17.0)
rubocop (= 0.87.1)
rubocop-rails (= 2.6.0)
rubocop-rake (= 0.5.1)
rubocop-rspec (= 1.39.0)
rubocop-rspec (= 1.42.0)
rubocop-rails (2.6.0)
activesupport (>= 4.2.0)
rack (>= 1.1)
rubocop (>= 0.82.0)
rubocop-rake (0.5.1)
rubocop
rubocop-rspec (1.39.0)
rubocop (>= 0.68.1)
rubocop-rspec (1.42.0)
rubocop (>= 0.87.0)
ruby-progressbar (1.10.1)
rubyzip (2.0.0)
safe_yaml (1.0.5)
Expand Down
8 changes: 4 additions & 4 deletions lib/tasks/data_import.rake
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ task data_import: ["data_import:sectors", "data_import:activities", "data_import
namespace :data_import do
desc "Import all data"
task all: :environment do
DataImporter::Sectors.update
DataImporter::Activities.update
DataImporter::Licences.update
DataImporter::Sectors.update!
DataImporter::Activities.update!
DataImporter::Licences.update!
end

desc "Import all sector data"
Expand All @@ -21,7 +21,7 @@ namespace :data_import do

desc "Import all licence data"
task licences: :environment do
DataImporter::Licences.update
DataImporter::Licences.update!
# Now migrate the imported licences to use the new gds_id
LicenceDataMigrator.migrate
end
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/data_importer_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
expect(importer).to receive(:run)
expect(DataImporter).to receive(:new).and_return(importer)

DataImporter.update
DataImporter.update!
end

it "closes import file even if an exception is raised" do
Expand Down