FreeBSD build script and patches #938
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks great. makefile change could go to kaldi repo indeed, maybe even to upstream kaldi, should we just wait for it then? |
|
I've summited an upstream PR to Kaldi master, kaldi-asr/kaldi#4733. |
|
Thanks! Few days then. |
|
Kaldi maintainers merged my FreeBSD patches into master: kaldi-asr/kaldi#4733 |
|
@tpoindex thanks, I've merged into our kaldi as well, now build should be easier. |
|
Great, I'll update this PR to exclude the inline patches to Kaldi, might not be for a few days. |
|
Updated the commit to remove the Kaldi in-stream patches, which are now included in upstream kaldi-asr/kaldi master as well as the alphacep/kaldi vosk branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for building Vosk-API under FreeBSD. A couple of notes: I didn't see a good place to stick the build script, so I create a 'misc' directory. There is a small patch to the upstream Kaldi to add FreeBSD support, currently it's inline in the build script, I'll also submit a PR to Kaldi for this. There a two small patches to Vosk files, one just adds FreeBSD support to the Python package, the other makes simple changes to c/Makefile to use generic$(CC) and $ (CXX) makefile definitions. All C/C++ compilation is done with clang in FreeBSD. Last, I've only tested building for C and Python.