Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken builds and adding README help with installing, building… #679

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agorman
Copy link

@agorman agorman commented Sep 1, 2021

…, and running

@agorman
Copy link
Author

agorman commented Sep 1, 2021

It would make things a bit cleaner if install and uninstall were added the the Makefile. So that the headers and library files would be recognized by the system. Would you be open to that?

@nshmyrev
Copy link
Collaborator

nshmyrev commented Sep 1, 2021

Hello. A big problem is that kaldi build process is very painful and not really manageable for ordinary users. I might accept build from vosk binary module which we distribute in releases. I don't think build from source is reasonable.

@agorman
Copy link
Author

agorman commented Sep 1, 2021

I didn't realize I could just download a release with libvosk.so 🤦‍♂️. I can update the README to reflect that rather than suggesting people install from source.

Another problem is the header files. doing a go get github.com/alphacep/vosk-api/go doesn't include the header files. Typically I've seen them included right in the same directory as the go source. I'll continue to look into that tomorrow but let me know if you have any ideas.

@agorman
Copy link
Author

agorman commented Sep 1, 2021

Take a look here https://github.com/agorman/govosk

A structure like that allows go get to be used to easily install the module. I don't think storing the .so file there is viable but would it be possible include a copy of the header files in the go directory? If so then the instructions could be to first install a release of vosk. Then just use go get as usual.

@nshmyrev
Copy link
Collaborator

nshmyrev commented Sep 2, 2021

would it be possible include a copy of the header files in the go directory?

I'd better add recommendation to download binary package from releases. We will include header file there together with library binary .so file.

I wonder how other popular modules handle this problem.

@agorman
Copy link
Author

agorman commented Sep 2, 2021

I'd better add recommendation to download binary package from releases. We will include header file there together with library binary .so file.

That works for me. For now I can just give instructions on what needs to be downloaded and environment variables to use. I'll wait until you have a package with both library and header.

In the future it would be nice to have a way to easily install vosk to the system. Do you have any plans to package vosk (deb, rpm, etc)?

I wonder how other popular modules handle this problem.

I think they assume the required libraries are installed on the system. I use these two libraries.

https://gocv.io/getting-started/linux/ - have OpenCV installed or alternatively follow their process to install it.

https://github.com/Kagami/go-face - assumes you have dlib installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants