Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bitcoin-bridge.md #3

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Update bitcoin-bridge.md #3

merged 2 commits into from
Oct 1, 2024

Conversation

john-light
Copy link
Contributor

Documentation Pull Request Template

Description

  • Style, grammar, and terminology updates
  • Updated details about the OP_RETURN structure

Type of Change

  • New Document
  • Update to Existing Document
  • Bug Fix
  • Question/clarification
  • Other (please describe):

Checklist

  • I have reviewed the existing documentation to avoid duplication.
  • The new or updated document includes clear and concise information.
  • All relevant sections (e.g., introduction, usage examples, references)
    are included.
  • The document follows the project's style guide and formatting rules.
  • I have included any necessary references or external resources.
  • Spellcheck and grammar check have been performed.
  • (For updates) I have verified that the changes reflect the current state
    of the project.

Reviewer Checklist

  • The purpose and scope of the document are clear.
  • The document is easy to understand and follow.
  • There are no typos or grammatical errors.
  • All necessary sections are included and well-structured.
  • The document is consistent with the project's style guide.
  • Any referenced links or resources are valid and appropriate.

Thank you for contributing to our documentation!

Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the ordered lists all at 1. since this implies better diffs we remove one element and under the hood it all renders properly

docs/technical/bitcoin-bridge.md Outdated Show resolved Hide resolved
docs/technical/bitcoin-bridge.md Outdated Show resolved Hide resolved
Copy link

@Rajil1213 Rajil1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't add a suggestion here since it's not part of the changes in this PR but there is another point that needs to be corrected. The NUMS point is not a lift_x(G) but rather constructed by taking the hash of the standard uncompressed encoding of the [secp256k1](https://www.secg.org/sec2-v2.pdf) base point G as X coordinate (according to the BIP).

@storopoli
Copy link
Member

@Rajil1213 CI is broken, while we fix that. Can you check if the NUMS correction in 2f8c78f meets your criteria?

@Rajil1213
Copy link

Can you check if the NUMS correction in 2f8c78f meets your criteria?

Yeah, it looks good now.

@storopoli storopoli merged commit 4c2f333 into main Oct 1, 2024
3 checks passed
@storopoli storopoli deleted the john-light-patch-2 branch October 1, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants