Update libspng, statically link zlib, and allow using zlib-ng #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates libspng to the latest commit and bumps the version of the crate. This libspng update includes enhancements to backward compatibility with libpng and implements previously no-op CRC actions. It also updates the bindgen.sh script to work with the latest bindgen version.
The implementation of FILE is different for several OSes, and previous commits checked for implementation-specific details that are not portable. Fix this by treating FILE as an opaque type.
aloucks
requested changes
Mar 14, 2021
|
Could you also add a CHANGELOG entry? Thanks! |
|
I've just addressed your comments in the latest commits. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rather big PR updates libspng to commit
264476a, updating the generated bindings, documentation, and bumping the version of the crate accordingly.It also links against zlib statically, because although that wastes the shared zlib library that may be installed on some systems, this allows following the expectation that Rust executables are as self-contained as possible, and reduces problems in case the end system has an incompatible version of zlib or has no zlib at all.
Also, the
--size_t-is-usizeparameter is added to thebuildgen.shscript because of relatively recent changes to bindgen; see rust-lang/rust-bindgen#1671.Finally, the
println!("include=libspng");call in thebuild.rsscript was removed, as it never did anything, because it should begin with thecargo:prefix for it to be honored somewhere. See https://kornel.ski/rust-sys-crate#headers for details.