Merge pull request quarkusio#37920 from mcruzdev/issue-37488

Fixes create and update goals docs
aloubyansky · Jan 25, 2024 · 52292c7 · 52292c7
2 parents f418d11 + d329744
commit 52292c7
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/docs/src/main/java/io/quarkus/docs/generation/QuarkusMavenPluginDocsGenerator.java b/docs/src/main/java/io/quarkus/docs/generation/QuarkusMavenPluginDocsGenerator.java
@@ -5,6 +5,7 @@
 import java.io.Reader;
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.util.Optional;
 
 import org.apache.maven.plugin.descriptor.MojoDescriptor;
 import org.apache.maven.plugin.descriptor.Parameter;
@@ -82,7 +83,11 @@ public static void main(String[] args) throws Exception {
             final GoalParamsBuilder goalParamsBuilder = goalsConfigDocBuilder.newGoalParamsBuilder();
             if (mojo.getParameters() != null) {
                 for (Parameter parameter : mojo.getParameters()) {
-                    goalParamsBuilder.addParam(parameter.getType(), parameter.getName(), parameter.getDefaultValue(),
+                    String property = getPropertyFromExpression(parameter.getExpression());
+
+                    String name = Optional.ofNullable(property).orElseGet(parameter::getName);
+
+                    goalParamsBuilder.addParam(parameter.getType(), name, parameter.getDefaultValue(),
                             parameter.isRequired(), parameter.getDescription());
                 }
             }
@@ -103,4 +108,16 @@ public static void main(String[] args) throws Exception {
         }
     }
 
+    private static String getPropertyFromExpression(String expression) {
+        if ((expression != null && !expression.isEmpty())
+                && expression.startsWith("${")
+                && expression.endsWith("}")
+                && !expression.substring(2).contains("${")) {
+            // expression="${xxx}" -> property="xxx"
+            return expression.substring(2, expression.length() - 1);
+        }
+        // no property can be extracted
+        return null;
+    }
+
 }