cross compile scala 3 #504
Conversation
i10416
force-pushed
the
feat-cross-compile-3
branch
from
c3d9c9d
to
a547e16
Compare
|
|
i10416
force-pushed
the
feat-cross-compile-3
branch
from
5b82bdf
to
03eb141
Compare
|
cron4s compiles in Scala 3! |
| val g = "https://raw.githubusercontent.com/alonsodomin/cron4s/" + tagOrHash | ||
| s"-P:scalajs:mapSourceURI:$a->$g/" | ||
| }, | ||
| scalacOptions ++= (if (scalaVersion.value.startsWith("2.")) Seq { |
There was a problem hiding this comment.
this causes bad option error in scala 3 scala.js: https://github.com/alonsodomin/cron4s/actions/runs/5435520680
| implicit lazy val arbitraryBetweenDayOfMonth = Arbitrary(betweenGen[DayOfMonth]) | ||
| implicit lazy val arbitraryBetweenMonth = Arbitrary(betweenGen[Month]) | ||
| implicit lazy val arbitraryBetweenDayOfWeek = Arbitrary(betweenGen[DayOfWeek]) | ||
| implicit lazy val arbitraryBetweenSecond: Arbitrary[BetweenNode[Second]] = Arbitrary( |
There was a problem hiding this comment.
explicit types for implicit vals/defs
| @@ -17,17 +17,22 @@ | |||
| package cron4s.testkit.gen | |||
|
|
|||
| import cron4s.CronField._ | |||
| import cron4s.expr.ConstNode | |||
|
|
|||
| import org.scalacheck.Arbitrary | |||
|
|
|||
| /** | |||
| * Created by alonsodomin on 28/08/2016. | |||
| */ | |||
| trait ArbitraryConstNode extends NodeGenerators { | |||
There was a problem hiding this comment.
explicit types for implicit vals/defs
| implicit lazy val arbitraryDaysOfMonthUnit = Arbitrary(Gen.const(CronUnit[DayOfMonth])) | ||
| implicit lazy val arbitraryMonthsUnit = Arbitrary(Gen.const(CronUnit[Month])) | ||
| implicit lazy val arbitraryDaysOfWeekUnit = Arbitrary(Gen.const(CronUnit[DayOfWeek])) | ||
| implicit lazy val arbitrarySecondsUnit: Arbitrary[CronUnit[Second]] = Arbitrary( |
There was a problem hiding this comment.
explicit types for implicit vals/defs
| ), | ||
| libraryDependencies ++= (if (scalaVersion.value.startsWith("2.")) | ||
| Seq("com.chuusai" %%% "shapeless" % version.shapeless) | ||
| else Seq.empty) |
There was a problem hiding this comment.
shapeless is no longer necessary in Scala 3. We can use union type and Tuple instead of Coproduct and HList.
| import cron4s.expr._ | ||
|
|
||
| import org.scalacheck._ | ||
|
|
There was a problem hiding this comment.
This file is almost the same as https://github.com/alonsodomin/cron4s/pull/504/files#diff-fe082e93829b26c97f89813516bdfd1efa4b2f6cc1d26d5dcd7aa2dcec929e03.
The differences are
- explicit type annotations for implicit vals/defs
- shapeless import removal
|
There are around 1700 lines of changes. However, changes in test and testkit modules are just explicit type annotations and imports for implicit conversions. There is a few changes in core modules, but most of them are just replacement from scala directory to scala-2 directory to hide shapeless from Scala 3. All tests pass for both Scala 2 and Scala 3. Therefore, I think whole changes in this PR are safe to some extent. |
|
@alonsodomin Hi, all cron4s modules compile in Scala 3 now. Please check when you have free time. |
complete #468
This PR supports cross build of all modules in Scala 3.
The most changes are introduced with the aim of hiding shapeless from shared files in core modules and filling the gap of implicit conversions and implicit defs/vals between scala 2.x and 3.x.
In addition, other changes address Scala 3 compiler/linter warnings.