Clean up / finish Factory #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenshively
commented
Sep 21, 2023
IanWoodard
approved these changes
Sep 21, 2023
| @@ -111,8 +111,7 @@ contract Borrower is IUniswapV3MintCallback { | |||
| TOKEN0 = lender0.asset(); | |||
| TOKEN1 = lender1.asset(); | |||
|
|
|||
| require(pool.token0() == address(TOKEN0)); | |||
| require(pool.token1() == address(TOKEN1)); | |||
| assert(pool.token0() == address(TOKEN0) && pool.token1() == address(TOKEN1)); | |||
There was a problem hiding this comment.
What is the difference between assert and require?
There was a problem hiding this comment.
require is usually used for checking external inputs, assert is for internal stuff. Since this data is coming from the Factory, I'm considering it internal.
I debated taking out the check entirely too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided not to implement a timelock here, as the only parameter it matters for is nSigma, and whatever
GOVERNORis implemented down the road will likely have a timelock built in.I did add event emission when parameters are changed, and added comments / organized stuff.