Fix pausing functionality #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenshively
force-pushed
the
get-prices-in-factory2
branch
from
62f0d06 to
37333e5
Compare
haydenshively
commented
Sep 12, 2023
Comment on lines
-17
to
-21
| function deploySingleBorrower(IUniswapV3Pool pool, Lender lender0, Lender lender1) returns (Borrower) { | ||
| address oracleMock = address(new VolatilityOracleMock()); | ||
| return new Borrower(VolatilityOracle(oracleMock), pool, lender0, lender1); | ||
| } | ||
|
|
haydenshively
commented
Sep 12, 2023
| contract BalanceSheetTest is Test { | ||
| function setUp() public {} | ||
|
|
||
| function test_alwaysHealthyWhenLiabilitiesAre0( |
There was a problem hiding this comment.
Since I moved the isHealthy check inside of the liabilities0 > 0 || liabilities1 > 0 conditional, I wanted to double check that no debt does, in fact, imply you're healthy. This test proves that.
aneesh1
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
LGTM. Also, looks like we have some major gas savings on repay!
IanWoodard
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
if (isSus) FACTORY.pauseline was kinda useless before, because ifisSuswas true, it would revert. Probably should've been caught in the audit, but at least I found it now.I removed that line from
modify(and reorganized that stuff a bit). Now to do apause, anyone can call the function in theFactory. It'll double check whether the prices are legit or not, and if they aren't, it'll pause the market.