Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra sig digs from IV and improve constants #152

Merged
merged 11 commits into from
Sep 11, 2023
Merged

Conversation

haydenshively
Copy link
Member

@haydenshively haydenshively commented Sep 11, 2023

Three things here:

  • Changed IV decimals from 18 to 12. 12 guarantees no overflow in the Volatility library, as opposed to just a strong unlikelihood. And 18 was way too many fake sig digs anyway.
  • Instead of clamping before multiplying by nSigma in BalanceSheet, we now do it afterwards. This will allow us to set nSigma to higher values without worrying about underflow.
  • Related to that clamping: I rewrote the min/max values in terms of loan-to-value. imo much clearer what they mean now

@haydenshively haydenshively merged commit 11e11c2 into master Sep 11, 2023
0 of 3 checks passed
@haydenshively haydenshively deleted the iv-precision branch September 11, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant