Skip to content

Commit

Permalink
Correct function signature in periphery managers (#188)
Browse files Browse the repository at this point in the history
  • Loading branch information
haydenshively authored Oct 12, 2023
1 parent 49df5d1 commit e220a1f
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion periphery/src/managers/BoostManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ contract BoostManager is IManager, IUniswapV3SwapCallback {
borrower.transfer(amount0 > 0 ? uint256(amount0) : 0, amount1 > 0 ? uint256(amount1) : 0, msg.sender);
}

function callback(bytes calldata data, address owner) external override returns (uint144) {
function callback(bytes calldata data, address owner, uint208) external override returns (uint208) {
// We cast `msg.sender` as a `Borrower`, but it could really be anything. DO NOT TRUST!
Borrower borrower = Borrower(payable(msg.sender));

Expand Down
2 changes: 1 addition & 1 deletion periphery/src/managers/FrontendManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ contract FrontendManager is IManager, IUniswapV3SwapCallback {

/* solhint-disable code-complexity */

function callback(bytes calldata data, address owner) external returns (uint144 positions) {
function callback(bytes calldata data, address owner, uint208) external returns (uint208 positions) {
// We cast `msg.sender` as a `Borrower`, but it could really be anything. DO NOT TRUST!
Borrower account = Borrower(payable(msg.sender));

Expand Down
2 changes: 1 addition & 1 deletion periphery/src/managers/SimpleManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ pragma solidity 0.8.17;
import {IManager} from "aloe-ii-core/Borrower.sol";

contract SimpleManager is IManager {
function callback(bytes calldata data, address) external override returns (uint144) {
function callback(bytes calldata data, address, uint208) external override returns (uint208) {
(bool success, ) = msg.sender.call(data); // solhint-disable-line avoid-low-level-calls
require(success);
return 0;
Expand Down
2 changes: 1 addition & 1 deletion periphery/src/managers/UniswapNFTManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ contract UniswapNFTManager is IManager {
NFT_MANAGER = nftManager;
}

function callback(bytes calldata data, address owner) external override returns (uint144 positions) {
function callback(bytes calldata data, address owner, uint208) external override returns (uint208 positions) {
Borrower borrower = Borrower(payable(msg.sender));

// The ID of the NFT to which liquidity will be added/removed
Expand Down

0 comments on commit e220a1f

Please sign in to comment.